Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include Hypre files in GNU make for 1D #1731

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

maximumcats
Copy link
Member

Summary

These files cannot be compiled in 1D, so there is no point in adding them.

Additional background

CMake treats this as fatal, but for Castro we would like to use the AMReX Hypre GNU make package even without the actual interfaces.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@WeiqunZhang WeiqunZhang merged commit 889af2f into AMReX-Codes:development Jan 16, 2021
@maximumcats maximumcats deleted the hypre_1D_gnumake branch January 16, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants