Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docs to reflect the new hypre options #1473

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

asalmgren
Copy link
Member

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@asalmgren asalmgren requested a review from drummerdoc October 21, 2020 20:40
Copy link
Member

@drummerdoc drummerdoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@@ -404,7 +404,8 @@ as living at face centroids, modify the setBCoeffs command to be
External Solvers
================

AMReX can use the `hypre <https://computing.llnl.gov/projects/hypre-scalable-linear-solvers-multigrid-methods>`_ algebraic multigrid solver, BoomerAMG,
AMReX can use the
`hypre <https://computing.llnl.gov/projects/hypre-scalable-linear-solvers-multigrid-methods>`_ algebraic multigrid solver, BoomerAMG,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asalmgren recommend updating this to reflect that we can now use BoomerAMG, GMRES (all variants), PCG, BiCGSTAB, from hypre as main solver. And BoomerAMG and Euclid as preconditioners.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added those -- thanks for pointing that out!

@WeiqunZhang WeiqunZhang merged commit 0cfd7d3 into AMReX-Codes:development Oct 22, 2020
@asalmgren asalmgren deleted the docs_update_for_hypre branch November 1, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants