Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: FindPETSc must not overwrite CMAKE_Fortran_FLAGS #1464

Merged
merged 1 commit into from
Oct 18, 2020
Merged

CMake: FindPETSc must not overwrite CMAKE_Fortran_FLAGS #1464

merged 1 commit into from
Oct 18, 2020

Conversation

mic84
Copy link
Contributor

@mic84 mic84 commented Oct 18, 2020

Summary

FindPETSc used to set CMAKE_Fortran_FLAGS to the list of PETSc include directories. This caused problems with the compilation of Fortran files (see Issue #1463 ). This PR fixes this.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@mic84 mic84 requested a review from WeiqunZhang October 18, 2020 03:42
@mic84 mic84 mentioned this pull request Oct 18, 2020
Closed
@WeiqunZhang WeiqunZhang merged commit aef02b9 into AMReX-Codes:development Oct 18, 2020
@mic84 mic84 deleted the mr/cmake-petsc-fortran-bug branch November 5, 2020 21:59
@sayerhs sayerhs mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mic84 @WeiqunZhang