Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EB interpolation from cell centers to faces #1443

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Fix EB interpolation from cell centers to faces #1443

merged 1 commit into from
Oct 8, 2020

Conversation

WeiqunZhang
Copy link
Member

##Summary
There were race conditions that made it fail on AMD GPUs.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@WeiqunZhang WeiqunZhang requested a review from asalmgren October 8, 2020 00:22
@WeiqunZhang
Fix EB interpolation from cell centers to faces
2bda65e 
There were race conditions that made it fail on AMD GPUs.
@WeiqunZhang WeiqunZhang merged commit 95ddfdb into AMReX-Codes:development Oct 8, 2020
@WeiqunZhang WeiqunZhang deleted the fix_eb_interp branch October 8, 2020 02:02
@sayerhs sayerhs mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalmgren asalmgren asalmgren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiqunZhang @asalmgren