Allow tagging value to vary by level #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximumcats
commented
Oct 7, 2020
| @@ -378,7 +378,7 @@ std::ostream& operator << (std::ostream& os, const ErrorList& elst); | |||
|
|
|||
| struct AMRErrorTagInfo | |||
| { | |||
| int m_max_level = 100000; | |||
| int m_max_level = 1000; | |||
There was a problem hiding this comment.
Note: I changed this just because we're now storing a vector of length m_max_level and I wanted to avoid it being gigantic, and no one will realistically have more than 1000 levels.
5 tasks
zingale
pushed a commit
to AMReX-Astro/Castro
that referenced
this pull request
Oct 13, 2020
We take advantage of AMReX-Codes/amrex#1441 to allow the user to specify a tagging threshold that can vary by level. If a value for every level is not provided, we assume the last value holds for all remaining levels, similar to how we treat quantities like amr.n_error_buf.
maximumcats
added a commit
to maximumcats/amrex
that referenced
this pull request
Oct 16, 2020
maximumcats
added a commit
to maximumcats/amrex
that referenced
this pull request
Oct 16, 2020
WeiqunZhang
pushed a commit
that referenced
this pull request
Oct 16, 2020
## Summary The user may have given us a vector that has too many values, so we just ignore the remainder. ## Additional background ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new error tagging scheme from #1166 is modified to allow the threshold value to vary by level. Using the example there, if we did:
Then level 0 would be tagged for refinement for Y(H) >= 1.e-6, while level 1 and all higher levels would be tagged for refinement for Y(H) >= 1.e-5. (If a value for every level is not provided, we assume the last value holds for all remaining levels, similar to how we treat quantities like amr.n_error_buf.)
Additional background
This will help for cases where a field varies substantially on the domain and you want to have better control over refinement so that you don't have too many zones.
Checklist
The proposed changes: