Avoid accessing device memory directly on host #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParticleLocator and ParticleTile contain vectors using device memory. To remove the dependency on unified memory we avoid accessing them directly on the host.
atmyers
approved these changes
Sep 17, 2020
WeiqunZhang
force-pushed
the
particle_um
branch
from
eebd96f to
98cb0e5
Compare
|
Forgot to push my latest commit with a typo corrected. |
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 18, 2020
They should not be removed in AMReX-Codes#1375.
5 tasks
WeiqunZhang
added a commit
that referenced
this pull request
Sep 18, 2020
## Summary They should not be removed in #1375. ## Additional background ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 18, 2020
A Bug was introduced in AMReX-Codes#1375. The host vector should have an initial size.
kweide
pushed a commit
to ECP-Astro/amrex
that referenced
this pull request
Sep 28, 2020
## Summary ParticleLocator and ParticleTile contain vectors using device memory. To remove the dependency on unified memory we avoid accessing them directly on the host. ## Additional background ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate
kweide
pushed a commit
to ECP-Astro/amrex
that referenced
this pull request
Sep 28, 2020
## Summary They should not be removed in AMReX-Codes#1375. ## Additional background ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate
kweide
pushed a commit
to ECP-Astro/amrex
that referenced
this pull request
Sep 28, 2020
A Bug was introduced in AMReX-Codes#1375. The host vector should have an initial size.
kweide
added a commit
to ECP-Astro/amrex
that referenced
this pull request
Sep 28, 2020
This reverts commit 84bf81b.
kweide
added a commit
to ECP-Astro/amrex
that referenced
this pull request
Sep 28, 2020
)" This reverts commit 9f42be9.
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
## Summary ParticleLocator and ParticleTile contain vectors using device memory. To remove the dependency on unified memory we avoid accessing them directly on the host. ## Additional background ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
## Summary They should not be removed in AMReX-Codes#1375. ## Additional background ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
A Bug was introduced in AMReX-Codes#1375. The host vector should have an initial size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ParticleLocator and ParticleTile contain vectors using device memory. To
remove the dependency on unified memory we avoid accessing them directly on
the host.
Additional background
Checklist
The proposed changes: