Fix uninitialized compiler warnings for: xslope yslope zslope #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
approved these changes
Sep 16, 2020
kweide
pushed a commit
to ECP-Astro/amrex
that referenced
this pull request
Sep 28, 2020
…Codes#1371) ## Summary Getting compiler warnings when building MFiX-Exa file that includes `AMReX_EB_slopes_K.H` ## Additional background Building with GCC 7.5.0: ``` ../src/convection/mfix_slopes.cpp: In member function 'void mfix::mfix_compute_slopes(int, amrex::Real, amrex::MultiFab&, const amrex::Vector<amrex::MultiFab*>&, const amrex::Vector<amrex::MultiFab*>&, const amrex::Vector<amrex::MultiFab*>&, int, std::map<std::__cxx11::basic_string<char>, amrex::PODVector<int, std::allocator<int> > >&)': ../src/convection/mfix_slopes.cpp:235:52: error: 'zslope' may be used uninitialized in this function [-Werror=maybe-uninitialized] zs_fab(i,j,k,slopes_comp+n) = eb_slopes[2]; ../src/convection/mfix_slopes.cpp:216:52: error: 'yslope' may be used uninitialized in this function [-Werror=maybe-uninitialized] ys_fab(i,j,k,slopes_comp+n) = eb_slopes[1]; ../src/convection/mfix_slopes.cpp:197:52: error: 'xslope' may be used uninitialized in this function [-Werror=maybe-uninitialized] xs_fab(i,j,k,slopes_comp+n) = eb_slopes[0]; ``` ## Checklist The proposed changes: - [X] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate Co-authored-by: Mark Meredith <mark.meredith@netl.doe.gov>
kweide
added a commit
to ECP-Astro/amrex
that referenced
this pull request
Sep 28, 2020
…AMReX-Codes#1371)" This reverts commit 7ad1a15.
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
…Codes#1371) ## Summary Getting compiler warnings when building MFiX-Exa file that includes `AMReX_EB_slopes_K.H` ## Additional background Building with GCC 7.5.0: ``` ../src/convection/mfix_slopes.cpp: In member function 'void mfix::mfix_compute_slopes(int, amrex::Real, amrex::MultiFab&, const amrex::Vector<amrex::MultiFab*>&, const amrex::Vector<amrex::MultiFab*>&, const amrex::Vector<amrex::MultiFab*>&, int, std::map<std::__cxx11::basic_string<char>, amrex::PODVector<int, std::allocator<int> > >&)': ../src/convection/mfix_slopes.cpp:235:52: error: 'zslope' may be used uninitialized in this function [-Werror=maybe-uninitialized] zs_fab(i,j,k,slopes_comp+n) = eb_slopes[2]; ../src/convection/mfix_slopes.cpp:216:52: error: 'yslope' may be used uninitialized in this function [-Werror=maybe-uninitialized] ys_fab(i,j,k,slopes_comp+n) = eb_slopes[1]; ../src/convection/mfix_slopes.cpp:197:52: error: 'xslope' may be used uninitialized in this function [-Werror=maybe-uninitialized] xs_fab(i,j,k,slopes_comp+n) = eb_slopes[0]; ``` ## Checklist The proposed changes: - [X] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] are described in the proposed changes to the AMReX documentation, if appropriate Co-authored-by: Mark Meredith <mark.meredith@netl.doe.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Getting compiler warnings when building MFiX-Exa file that includes
AMReX_EB_slopes_K.HAdditional background
Building with GCC 7.5.0:
Checklist
The proposed changes: