Add support for extended particle range to the Fortran interfaces #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
reviewed
Sep 2, 2020
| @@ -56,15 +58,43 @@ end subroutine amrex_fi_delete_particlecontainer | |||
| subroutine amrex_fi_get_next_particle_id (id) bind(c) | |||
| import | |||
| implicit none | |||
| integer(c_int) id | |||
| integer(c_long) id | |||
There was a problem hiding this comment.
We should use amrex_long from the amrex_fort_module.
WeiqunZhang
approved these changes
Sep 2, 2020
kweide
pushed a commit
to ECP-Astro/amrex
that referenced
this pull request
Sep 28, 2020
…ReX-Codes#1331) * add support for extended particle range to the Fortran interfaces * replace c_long -> amrex_long for Windows support
kweide
added a commit
to ECP-Astro/amrex
that referenced
this pull request
Sep 28, 2020
…aces (AMReX-Codes#1331)" This reverts commit ffd83c9.
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
…ReX-Codes#1331) * add support for extended particle range to the Fortran interfaces * replace c_long -> amrex_long for Windows support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed changes: