MacProjector: allow for re-use of the object and enhance multi-level algorithm. #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mic84
changed the title
mic84
changed the title
asalmgren
approved these changes
Aug 7, 2020
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
…algorithm. (AMReX-Codes#1225) * MacProjector: build RHS each time project() is called * MacProjector: average down velocities before and after projection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally the MacProjector object was not designed to be re-used for multiple solves, i.e. it had to be created anew for each solve. Furthermore, it was up to the user to average down velocities before and after the projection for multi-level solves.
This bug enhance the behavior of the MacProjector by
Additional background
Checklist
The proposed changes: