Skip to content

Commit

Permalink
CI: Windows MSVC w/ Ninja (#3804)
Browse files Browse the repository at this point in the history
## Summary

It looks like `-G "Ninja"` swapped the compiler from MSVC to MinGW
(GCC). This ensures MSVC is actually used and tested in CI.

## Additional background

Extracted from #3803
  • Loading branch information
ax3l authored Mar 14, 2024
1 parent 431ad98 commit 5c849fd
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
#ccache -z
cmake -S . -B build `
-G "Ninja" `
-DCMAKE_BUILD_TYPE=Debug `
-DBUILD_SHARED_LIBS=ON `
-DCMAKE_VERBOSE_MAKEFILE=ON `
Expand Down Expand Up @@ -81,7 +80,6 @@ jobs:
#ccache -z
cmake -S . -B build `
-G "Ninja" `
-DCMAKE_BUILD_TYPE=RelWithDebInfo `
-DCMAKE_VERBOSE_MAKEFILE=ON `
-DAMReX_EB=ON `
Expand Down

0 comments on commit 5c849fd

Please sign in to comment.