Skip to content

some fixes for true SDC#3307

Open
zingale wants to merge 4 commits intoAMReX-Astro:developmentfrom
zingale:fix_sdc_clang
Open

some fixes for true SDC#3307
zingale wants to merge 4 commits intoAMReX-Astro:developmentfrom
zingale:fix_sdc_clang

Conversation

@zingale
Copy link
Member

@zingale zingale commented Mar 8, 2026

we were not using the correct number of source ghost cells when the shock variable was defined

also lots of clang-tidy fixes

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

zingale added 3 commits March 8, 2026 11:43
we were not using the correct number of source ghost cells when
the shock variable was defined

also lots of clang-tidy fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant