Support the notify/v2 interface for all services #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service notify API requires Rx to implement sensibly, so just make it a fixed dependency. Any service which isn't providing notify/v2 probably should be.
Now I have a means of generating correct package-lock files, we should be committing them to the repo.
This should prevent incorrect package-lock files from being produced.
There is no good idiom in Javascript for 'copy this object without this key'.
Refactor using Optional and a function from Session to Observable to avoid needing to pass the Session around.
I don't like this API design; smashing more and more into a set of function arguments isn't a good idea.
This makes sure we use a configured local npm registry where appropriate.
djnewbould
requested changes
Nov 6, 2024
* Minor tweaks. * Comments for the Rx code.
djnewbould
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the implementation of the
notify/v2interface into this module, so that all F+ services can implement it.Support SEARCH notify requests.