Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 9, 2025

Related to #3041.

And fix type annotations.

@dweindl dweindl self-assigned this Dec 9, 2025
@dweindl dweindl force-pushed the mv_petab_sim_v2 branch 3 times, most recently from 99df343 to 3f59a7d Compare December 9, 2025 18:31
Related to AMICI-dev#3041.

And fix type annotations.
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 94.09283% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.54%. Comparing base (c64ec7a) to head (4ba54fc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/sim/sundials/petab/_v2.py 94.06% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3093      +/-   ##
==========================================
- Coverage   78.17%   77.54%   -0.64%     
==========================================
  Files         313      315       +2     
  Lines       20469    20472       +3     
  Branches     1500     1501       +1     
==========================================
- Hits        16002    15875     -127     
- Misses       4458     4588     +130     
  Partials        9        9              
Flag Coverage Δ
cpp 71.68% <11.81%> (+0.02%) ⬆️
cpp_python 37.67% <11.81%> (+<0.01%) ⬆️
petab 46.38% <88.18%> (+<0.01%) ⬆️
petab_sciml 13.74% <0.00%> (-0.01%) ⬇️
python 70.33% <93.67%> (+0.03%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/adapters/fiddy.py 78.51% <ø> (ø)
python/sdist/amici/importers/petab/__init__.py 100.00% <ø> (ø)
...hon/sdist/amici/importers/petab/_petab_importer.py 86.78% <ø> (-2.91%) ⬇️
python/sdist/amici/sim/sundials/petab/__init__.py 100.00% <100.00%> (ø)
python/sdist/amici/sim/sundials/petab/_v2.py 94.06% <94.06%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review December 9, 2025 19:29
@dweindl dweindl requested a review from a team as a code owner December 9, 2025 19:29
@dweindl dweindl added this pull request to the merge queue Dec 10, 2025
Merged via the queue into AMICI-dev:main with commit 1a80258 Dec 10, 2025
25 of 26 checks passed
@dweindl dweindl deleted the mv_petab_sim_v2 branch December 10, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants