Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 15, 2025

and all petab v1 functionality to amici.importers.petab.v1.

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.10%. Comparing base (d8c41f3) to head (bbd34ee).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
+ Coverage   77.39%   78.10%   +0.70%     
==========================================
  Files         311      311              
  Lines       20604    20580      -24     
  Branches     1499     1500       +1     
==========================================
+ Hits        15947    16073     +126     
+ Misses       4647     4497     -150     
  Partials       10       10              
Flag Coverage Δ
cpp 70.71% <33.33%> (+0.38%) ⬆️
cpp_python 37.19% <33.33%> (+0.37%) ⬆️
petab 45.86% <33.33%> (+0.06%) ⬆️
petab_sciml 13.75% <100.00%> (+0.03%) ⬆️
python 69.37% <33.33%> (+0.03%) ⬆️
sbmlsuite-jax 31.38% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/adapters/fiddy.py 78.51% <ø> (-0.16%) ⬇️
python/sdist/amici/importers/petab/__init__.py 100.00% <100.00%> (ø)
...hon/sdist/amici/importers/petab/_petab_importer.py 89.69% <ø> (ø)
python/sdist/amici/importers/petab/v1/__init__.py 100.00% <ø> (ø)
...ython/sdist/amici/importers/petab/v1/conditions.py 98.33% <ø> (ø)
...n/sdist/amici/importers/petab/v1/import_helpers.py 85.71% <ø> (ø)
...dist/amici/importers/petab/v1/parameter_mapping.py 85.37% <ø> (ø)
...hon/sdist/amici/importers/petab/v1/petab_import.py 100.00% <ø> (ø)
...on/sdist/amici/importers/petab/v1/petab_problem.py 89.23% <ø> (ø)
...thon/sdist/amici/importers/petab/v1/pysb_import.py 61.76% <ø> (ø)
... and 10 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
Copy link
Member Author

dweindl commented Nov 15, 2025

TODO:

@dweindl dweindl force-pushed the petab_subpackage branch 2 times, most recently from 8fe5ffd to 2fe2b4a Compare November 15, 2025 13:04
@dweindl dweindl marked this pull request as ready for review November 15, 2025 13:59
@dweindl dweindl requested a review from a team as a code owner November 15, 2025 13:59
@dweindl dweindl self-assigned this Nov 15, 2025
dweindl added a commit to dweindl/pyPESTO that referenced this pull request Nov 15, 2025
The example will be added to pypesto (currently only on ICB-DCM/pyPESTO#1619).
This finally gets rid of the circular dependency with pypesto.

Closes AMICI-dev#3042.
and all petab v1 functionality to amici.importers.petab.v1.
@dweindl dweindl enabled auto-merge November 15, 2025 15:06
@dweindl dweindl added this pull request to the merge queue Nov 15, 2025
Merged via the queue into AMICI-dev:main with commit 9c82549 Nov 15, 2025
29 checks passed
@dweindl dweindl deleted the petab_subpackage branch November 15, 2025 21:05
dweindl added a commit to dweindl/pyPESTO that referenced this pull request Nov 15, 2025
dweindl added a commit to dweindl/pyPESTO that referenced this pull request Dec 3, 2025
dweindl added a commit to dweindl/pyPESTO that referenced this pull request Dec 3, 2025
dweindl added a commit to dweindl/pyPESTO that referenced this pull request Dec 9, 2025
dweindl added a commit to dweindl/pyPESTO that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants