-
Notifications
You must be signed in to change notification settings - Fork 32
Move amici.petab to amici.importers.petab #3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86bae13 to
07de7eb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3039 +/- ##
==========================================
+ Coverage 77.39% 78.10% +0.70%
==========================================
Files 311 311
Lines 20604 20580 -24
Branches 1499 1500 +1
==========================================
+ Hits 15947 16073 +126
+ Misses 4647 4497 -150
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
07de7eb to
560039e
Compare
Member
Author
|
TODO:
|
560039e to
696e3d1
Compare
7 tasks
8fe5ffd to
2fe2b4a
Compare
dweindl
added a commit
to dweindl/pyPESTO
that referenced
this pull request
Nov 15, 2025
This reverts commit 74b33ca.
FFroehlich
approved these changes
Nov 15, 2025
The example will be added to pypesto (currently only on ICB-DCM/pyPESTO#1619). This finally gets rid of the circular dependency with pypesto. Closes AMICI-dev#3042.
and all petab v1 functionality to amici.importers.petab.v1.
2fe2b4a to
bbd34ee
Compare
dweindl
added a commit
to dweindl/pyPESTO
that referenced
this pull request
Nov 15, 2025
This reverts commit 70e3af0.
dweindl
added a commit
to dweindl/pyPESTO
that referenced
this pull request
Dec 3, 2025
This reverts commit 74b33ca.
dweindl
added a commit
to dweindl/pyPESTO
that referenced
this pull request
Dec 3, 2025
This reverts commit 70e3af0.
dweindl
added a commit
to dweindl/pyPESTO
that referenced
this pull request
Dec 9, 2025
This reverts commit 74b33ca.
dweindl
added a commit
to dweindl/pyPESTO
that referenced
this pull request
Dec 9, 2025
This reverts commit 70e3af0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and all petab v1 functionality to amici.importers.petab.v1.