Support for event priorities #2730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2730 +/- ##
===========================================
+ Coverage 77.94% 77.95% +0.01%
===========================================
Files 327 327
Lines 23065 23079 +14
Branches 1484 1484
===========================================
+ Hits 17977 17991 +14
Misses 5077 5077
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
event_priority
branch
3 times, most recently
from
7126ffc to
0929828
Compare
Support plain numeric priorities of SBML events (not the arbitrary expressions that SBML would allow). Also removes an incorrect check for whether we support useValueFromTriggerTime.
FFroehlich
approved these changes
May 17, 2025
| pending_events_.sort([](Event const& a, Event const& b) { | ||
| // The priority is NaN if not defined. In this case, the execution | ||
| // order is undefined, so this does not need any special treatment. | ||
| return a.get_priority() > b.get_priority(); |
There was a problem hiding this comment.
what about mixed defined and undefined event priories (sbml spec says we can do whathever we want with undefined prios). Also in the case of equal priority SBML spec says events should be picked randomly.
| @@ -736,6 +737,13 @@ def __init__( | |||
| self._state_update = state_update | |||
| self._initial_value = initial_value | |||
|
|
|||
| if priority is not None and not priority.is_Number: | |||
| raise NotImplementedError( | |||
| "Only fixed numbers are currently supported as event priority." | |||
There was a problem hiding this comment.
Suggested change
| "Only fixed numbers are currently supported as event priority." | |
| "Currently, only numeric values are supported as event priority." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support plain numeric priorities of SBML events (not the arbitrary expressions that SBML would allow).
If there are multiple event assignments to be executed at the same model time, the ones with higher priority values come first.
Closes #2718.
Also:
useValueFromTriggerTime=True