Use Model.setAlwaysCheckFinite(True) in debug builds#2262
Merged
dweindl merged 4 commits intoAMICI-dev:developfrom Jan 7, 2024
Merged
Use Model.setAlwaysCheckFinite(True) in debug builds#2262dweindl merged 4 commits intoAMICI-dev:developfrom
dweindl merged 4 commits intoAMICI-dev:developfrom
Conversation
So that we automatically use the additional checks in our tests. Closes AMICI-dev#2235
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2262 +/- ##
===========================================
+ Coverage 76.47% 77.08% +0.61%
===========================================
Files 92 92
Lines 14976 14980 +4
===========================================
+ Hits 11453 11548 +95
+ Misses 3523 3432 -91
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Jan 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we automatically use the additional checks in our tests.
Closes #2235