Skip to content

Conversation

@FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Mar 3, 2023

Not sure what this is about? is parameter table intentionally not passed to import_model?

@FFroehlich FFroehlich requested a review from a team as a code owner March 3, 2023 11:42
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #2030 (2001a71) into develop (e2d38ed) will decrease coverage by 4.29%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2030      +/-   ##
===========================================
- Coverage    76.02%   71.73%   -4.29%     
===========================================
  Files           75       72       -3     
  Lines        13009    12919      -90     
===========================================
- Hits          9890     9268     -622     
- Misses        3119     3651     +532     
Flag Coverage Δ
cpp 72.84% <ø> (ø)
petab ?
python 69.62% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/petab_import.py 0.00% <ø> (-65.50%) ⬇️
python/sdist/amici/petab_simulate.py 0.00% <0.00%> (-100.00%) ⬇️
python/sdist/amici/petab_objective.py 0.00% <0.00%> (-93.44%) ⬇️
python/sdist/amici/petab_import_pysb.py 0.00% <0.00%> (-92.60%) ⬇️
python/sdist/amici/parameter_mapping.py 40.15% <0.00%> (-37.13%) ⬇️
python/sdist/amici/pysb_import.py 91.94% <0.00%> (-2.69%) ⬇️
python/sdist/amici/sbml_import.py 75.83% <0.00%> (-0.90%) ⬇️
python/tests/test_petab_import.py
python/tests/conftest.py
... and 1 more

@FFroehlich
Copy link
Member Author

looks like this was potentially intended

@FFroehlich FFroehlich closed this Mar 3, 2023
@FFroehlich FFroehlich deleted the fix_petab_import branch March 3, 2023 14:24
@dweindl
Copy link
Member

dweindl commented Mar 8, 2023

Not sure what this is about? is parameter table intentionally not passed to import_model?

Until recently, the parameters table wasn't used for model import. But I don't see why including it would break anything. The failures above were related to the restructured petab test suite (#2032 , PEtab-dev/petab_test_suite#53).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants