Skip to content

Simplify OpenBLAS installation on Windows - #2016

Merged
dweindl merged 1 commit into
developfrom
simplify_openblas
Feb 23, 2023
Merged

Simplify OpenBLAS installation on Windows#2016
dweindl merged 1 commit into
developfrom
simplify_openblas

Conversation

@dweindl

@dweindl dweindl commented Feb 23, 2023

Copy link
Copy Markdown
Member
  • Use cmake-install instead of funny manual copying
  • Build parallel
  • Upload build artifacts for debugging
  • Silence stupid MSVC copyright messages

* Use cmake-install instead of funny manual copying
* Build parallel
* Upload build artifacts for debugging
* Silence stupid MSVC copyright messages
@dweindl
dweindl requested a review from a team as a code owner February 23, 2023 14:21
@codecov

codecov Bot commented Feb 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2016 (9324813) into develop (cfe49a1) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2016      +/-   ##
===========================================
+ Coverage    76.16%   76.18%   +0.02%     
===========================================
  Files           76       76              
  Lines        13004    13004              
===========================================
+ Hits          9904     9907       +3     
+ Misses        3100     3097       -3     
Flag Coverage Δ
cpp 73.40% <ø> (+0.03%) ⬆️
petab 60.03% <ø> (ø)
python 68.85% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solver_cvodes.cpp 70.39% <0.00%> (+0.16%) ⬆️
src/exception.cpp 80.00% <0.00%> (+5.71%) ⬆️

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FFroehlich FFroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl
dweindl merged commit 2aef279 into develop Feb 23, 2023
@dweindl
dweindl deleted the simplify_openblas branch February 23, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants