Skip to content

Matlab: If mex fails, print mex arguments - #2013

Merged
dweindl merged 1 commit into
developfrom
fix_913_mex
Feb 22, 2023
Merged

Matlab: If mex fails, print mex arguments#2013
dweindl merged 1 commit into
developfrom
fix_913_mex

Conversation

@dweindl

@dweindl dweindl commented Feb 22, 2023

Copy link
Copy Markdown
Member

For all mex calls, catch exception, print mex invocation, rethrow. Will make bug reports way more informative and simplify debugging.

Resolves #913

For all mex calls, catch exception, print mex invocation, rethrow. Will make bug reports way more informative and simplify debugging.

Resolves #913
@dweindl
dweindl requested a review from a team as a code owner February 22, 2023 11:01
@codecov

codecov Bot commented Feb 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2013 (05aa50d) into develop (34057d1) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2013      +/-   ##
===========================================
+ Coverage    76.16%   76.26%   +0.09%     
===========================================
  Files           76       76              
  Lines        13004    13004              
===========================================
+ Hits          9904     9917      +13     
+ Misses        3100     3087      -13     
Flag Coverage Δ
cpp 73.36% <ø> (ø)
petab 60.03% <ø> (ø)
python 69.14% <ø> (+0.28%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/gradient_check.py 96.84% <0.00%> (+13.68%) ⬆️

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FFroehlich FFroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl
dweindl merged commit cfe49a1 into develop Feb 22, 2023
@dweindl
dweindl deleted the fix_913_mex branch February 22, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants