Skip to content

don't pass -py3 to swig after 4.1.0 - #2010

Merged
FFroehlich merged 2 commits into
developfrom
fix_swig
Feb 22, 2023
Merged

don't pass -py3 to swig after 4.1.0#2010
FFroehlich merged 2 commits into
developfrom
fix_swig

Conversation

@FFroehlich

Copy link
Copy Markdown
Member

@FFroehlich
FFroehlich requested a review from a team as a code owner February 21, 2023 19:45
@codecov

codecov Bot commented Feb 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2010 (3e11275) into develop (bd37745) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2010      +/-   ##
===========================================
+ Coverage    75.99%   76.08%   +0.08%     
===========================================
  Files           76       76              
  Lines        12996    12998       +2     
===========================================
+ Hits          9876     9889      +13     
+ Misses        3120     3109      -11     
Flag Coverage Δ
cpp 73.24% <ø> (+0.03%) ⬆️
petab 60.03% <0.00%> (-0.03%) ⬇️
python 68.85% <0.00%> (+0.19%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/setuptools.py 57.40% <0.00%> (-1.09%) ⬇️
src/solver_cvodes.cpp 70.23% <0.00%> (+0.16%) ⬆️
...thon/sdist/amici/conserved_quantities_demartino.py 65.55% <0.00%> (+1.95%) ⬆️
src/exception.cpp 80.00% <0.00%> (+5.71%) ⬆️

@FFroehlich
FFroehlich merged commit a77a030 into develop Feb 22, 2023
@FFroehlich
FFroehlich deleted the fix_swig branch February 22, 2023 08:30
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants