Change default ReturnData::status to AMICI_NOT_RUN - #1984
Merged
Conversation
So far, if a simulation with `runAmiciSimulations(...., failfast=True)` failed, an empty `ReturnData` with `status=AMICI_SUCCESS` was returned for the skipped conditions. This was rather confusing. This adds a new status: `AMICI_NOT_RUN`. Fixes #1949
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1984 +/- ##
========================================
Coverage 59.72% 59.72%
========================================
Files 30 30
Lines 4584 4584
========================================
Hits 2738 2738
Misses 1846 1846
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, if a simulation with
runAmiciSimulations(...., failfast=True)failed, an emptyReturnDatawithstatus=AMICI_SUCCESSwas returned for the skipped conditions. This was rather confusing.This adds a new status:
AMICI_NOT_RUN.Fixes #1949