Skip to content

Use temporary directories for test models - #1971

Merged
dweindl merged 3 commits into
developfrom
tests_tmpdir
Feb 1, 2023
Merged

Use temporary directories for test models#1971
dweindl merged 3 commits into
developfrom
tests_tmpdir

Conversation

@dweindl

@dweindl dweindl commented Jan 31, 2023

Copy link
Copy Markdown
Member

Ensures they are gone after running tests.

Ensures they are gone after running tests.
@dweindl
dweindl requested a review from a team as a code owner January 31, 2023 17:54
@codecov

codecov Bot commented Jan 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1971 (2b3d79a) into develop (77c5339) will decrease coverage by 4.28%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1971      +/-   ##
===========================================
- Coverage    75.98%   71.71%   -4.28%     
===========================================
  Files           76       73       -3     
  Lines        12984    12899      -85     
===========================================
- Hits          9866     9250     -616     
- Misses        3118     3649     +531     
Flag Coverage Δ
cpp 73.17% <ø> (+0.02%) ⬆️
petab ?
python 68.97% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/petab_simulate.py 0.00% <0.00%> (-100.00%) ⬇️
python/sdist/amici/petab_objective.py 0.00% <0.00%> (-93.44%) ⬇️
python/sdist/amici/petab_import_pysb.py 0.00% <0.00%> (-92.60%) ⬇️
python/sdist/amici/petab_import.py 0.00% <0.00%> (-65.34%) ⬇️
python/sdist/amici/parameter_mapping.py 40.15% <0.00%> (-37.13%) ⬇️
python/sdist/amici/setuptools.py 52.88% <0.00%> (-6.74%) ⬇️
python/sdist/amici/custom_commands.py 34.37% <0.00%> (-3.13%) ⬇️
python/sdist/amici/pysb_import.py 91.94% <0.00%> (-2.69%) ⬇️
python/sdist/amici/sbml_import.py 80.35% <0.00%> (-0.69%) ⬇️
python/tests/conftest.py
... and 3 more

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl
dweindl merged commit 97f7438 into develop Feb 1, 2023
@dweindl
dweindl deleted the tests_tmpdir branch February 1, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants