Fix PytestReturnNotNoneWarning in test_conserved_quantities_demartino.py by dweindl · Pull Request #1968 · AMICI-dev/AMICI

dweindl · 2023-01-31T14:25:01Z

Fixes

  C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but python/tests/test_conserved_quantities_demartino.py::test_compute_moiety_conservation_laws_demartino2014 returned 7.324800299999993, which will be an error in a future version of pytest.  Did you mean to use `assert` instead of `return`?

Fixes ``` C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but python/tests/test_conserved_quantities_demartino.py::test_compute_moiety_conservation_laws_demartino2014 returned 7.324800299999993, which will be an error in a future version of pytest. Did you mean to use `assert` instead of `return`? ```

codecov · 2023-01-31T14:37:15Z

Codecov Report

Merging #1968 (d3d51c3) into develop (b61abb6) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1968      +/-   ##
===========================================
- Coverage    75.98%   75.97%   -0.01%     
===========================================
  Files           76       76              
  Lines        12984    12984              
===========================================
- Hits          9866     9865       -1     
- Misses        3118     3119       +1

Flag	Coverage Δ
cpp	`73.13% <ø> (-0.02%)`	⬇️
petab	`59.71% <ø> (ø)`
python	`68.97% <ø> (ø)`
sbmlsuite	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/amici.cpp	`71.77% <0.00%> (-4.04%)`	⬇️
src/exception.cpp	`74.28% <0.00%> (ø)`
src/solver_cvodes.cpp	`70.06% <0.00%> (ø)`
src/sundials_matrix_wrapper.cpp	`81.02% <0.00%> (+0.81%)`	⬆️