Skip to content

Add --no-validate to amici_import_petab - #1963

Merged
dweindl merged 1 commit into
developfrom
cli_petab_novalidate
Jan 30, 2023
Merged

Add --no-validate to amici_import_petab#1963
dweindl merged 1 commit into
developfrom
cli_petab_novalidate

Conversation

@dweindl

@dweindl dweindl commented Jan 29, 2023

Copy link
Copy Markdown
Member

to skip PEtab validation

@dweindl
dweindl requested a review from a team as a code owner January 29, 2023 09:04
@codecov

codecov Bot commented Jan 29, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1963 (43344fd) into develop (13cde9d) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1963      +/-   ##
===========================================
+ Coverage    75.99%   76.01%   +0.01%     
===========================================
  Files           76       76              
  Lines        12982    12984       +2     
===========================================
+ Hits          9866     9870       +4     
+ Misses        3116     3114       -2     
Flag Coverage Δ
cpp 73.19% <ø> (+0.04%) ⬆️
petab 59.71% <0.00%> (-0.03%) ⬇️
python 68.97% <0.00%> (-0.04%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/petab_import.py 65.33% <0.00%> (-0.53%) ⬇️
src/sundials_matrix_wrapper.cpp 81.02% <0.00%> (+0.81%) ⬆️

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl
dweindl merged commit 672f88d into develop Jan 30, 2023
@dweindl
dweindl deleted the cli_petab_novalidate branch January 30, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants