Change default interpolation type from hermite to polynomial - #1960
Merged
Conversation
According to [CVODES docs](https://sundials.readthedocs.io/en/latest/cvodes/Mathematics_link.html#checkpointing-scheme), polynomial should be the better choice: > The variable-degree polynomial is more memory-efficient (it requires only half of the memory storage of the cubic Hermite interpolation) and is more accurate.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1960 +/- ##
===========================================
- Coverage 76.03% 75.92% -0.12%
===========================================
Files 76 76
Lines 12982 12982
===========================================
- Hits 9871 9856 -15
- Misses 3111 3126 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to CVODES docs, polynomial should be the better choice: