Skip to content

add ExpData __repr__ - #1948

Merged
FFroehlich merged 12 commits into
developfrom
better_repr
Jan 24, 2023
Merged

add ExpData __repr__ #1948
FFroehlich merged 12 commits into
developfrom
better_repr

Conversation

@FFroehlich

@FFroehlich FFroehlich commented Jan 18, 2023

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jan 18, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1948 (c2cd288) into develop (c25c666) will increase coverage by 0.11%.
The diff coverage is 50.00%.

❗ Current head c2cd288 differs from pull request most recent head 3de1693. Consider uploading reports for the commit 3de1693 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1948      +/-   ##
===========================================
+ Coverage    75.96%   76.08%   +0.11%     
===========================================
  Files           76       76              
  Lines        12979    12981       +2     
===========================================
+ Hits          9860     9876      +16     
+ Misses        3119     3105      -14
Flag Coverage Δ
cpp 73.15% <ø> (+0.02%) ⬆️
petab 59.68% <50.00%> (-0.01%) ⬇️
python 69.23% <50.00%> (+0.28%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/numpy.py 81.72% <50.00%> (-0.70%) ⬇️
src/sundials_matrix_wrapper.cpp 81.02% <0.00%> (+0.40%) ⬆️
python/sdist/amici/gradient_check.py 96.84% <0.00%> (+13.68%) ⬆️

@FFroehlich
FFroehlich requested a review from dweindl January 18, 2023 18:54
dweindl
dweindl approved these changes Jan 18, 2023
View reviewed changes
Comment thread swig/edata.i Outdated
Comment thread swig/edata.i Outdated
Comment thread swig/edata.i
dweindl
dweindl reviewed Jan 18, 2023
View reviewed changes
Comment thread swig/edata.i
@FFroehlich
FFroehlich requested a review from dweindl January 19, 2023 14:59
dweindl
dweindl approved these changes Jan 24, 2023
View reviewed changes

@dweindl dweindl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread python/sdist/amici/numpy.py Outdated
FFroehlich and others added 2 commits January 24, 2023 13:01
@FFroehlich @dweindl
Update python/sdist/amici/numpy.py
3de1693 
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Fabian Fröhlich
Merge branch 'develop' into better_repr
5bd3d3f
@FFroehlich
FFroehlich merged commit 9ef2e36 into develop Jan 24, 2023
@FFroehlich
FFroehlich deleted the better_repr branch January 24, 2023 12:10
@sonarqubecloud

sonarqubecloud Bot commented Jan 24, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl linked an issue Jan 24, 2023 that may be closed by this pull request
Add more informative __repr__ for ExpData & ExpDataView #1941
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dweindl dweindl dweindl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add more informative __repr__ for ExpData & ExpDataView

2 participants

@FFroehlich @dweindl