Skip to content

increase benchmark reference times for most common failures - #1945

Merged
FFroehlich merged 1 commit into
developfrom
fix_1914
Jan 18, 2023
Merged

increase benchmark reference times for most common failures#1945
FFroehlich merged 1 commit into
developfrom
fix_1914

Conversation

@FFroehlich

Copy link
Copy Markdown
Member

fixes #1914

I thought there are @flaky or @rerun decorators for individual tests in pytest, but didn't find anything helpful

@codecov

codecov Bot commented Jan 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1945 (26cda0e) into develop (41f1691) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1945      +/-   ##
===========================================
+ Coverage    75.94%   75.98%   +0.03%     
===========================================
  Files           76       76              
  Lines        12977    12977              
===========================================
+ Hits          9856     9860       +4     
+ Misses        3121     3117       -4     
Flag Coverage Δ
cpp 73.15% <ø> (+0.04%) ⬆️
petab 59.66% <ø> (ø)
python 68.94% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solver_cvodes.cpp 70.23% <0.00%> (+0.16%) ⬆️
src/sundials_matrix_wrapper.cpp 80.40% <0.00%> (+0.20%) ⬆️
src/exception.cpp 80.00% <0.00%> (+5.71%) ⬆️

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@FFroehlich
FFroehlich requested a review from dweindl January 18, 2023 12:57
@dweindl

dweindl commented Jan 18, 2023

Copy link
Copy Markdown
Member

I thought there are @flaky or @rerun decorators for individual tests in pytest, but didn't find anything helpful

https://github.com/pytest-dev/pytest-rerunfailures

@FFroehlich

Copy link
Copy Markdown
Member Author

I thought there are @flaky or @rerun decorators for individual tests in pytest, but didn't find anything helpful

https://github.com/pytest-dev/pytest-rerunfailures

d'oh, this script doesn't even use pytest :(

@FFroehlich
FFroehlich merged commit 32db671 into develop Jan 18, 2023
@FFroehlich
FFroehlich deleted the fix_1914 branch January 18, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants