Skip to content

Prepare for binder - #1935

Merged
dweindl merged 3 commits into
developfrom
binder
Jan 16, 2023
Merged

Prepare for binder#1935
dweindl merged 3 commits into
developfrom
binder

Conversation

@dweindl

@dweindl dweindl commented Jan 15, 2023

Copy link
Copy Markdown
Member

Try it - Binder

@codecov

codecov Bot commented Jan 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1935 (84ec733) into develop (7f1eee3) will increase coverage by 0.20%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1935      +/-   ##
===========================================
+ Coverage    75.90%   76.11%   +0.20%     
===========================================
  Files           76       76              
  Lines        12970    12970              
===========================================
+ Hits          9845     9872      +27     
+ Misses        3125     3098      -27     
Flag Coverage Δ
cpp 73.15% <ø> (+0.04%) ⬆️
petab 59.72% <ø> (ø)
python 69.31% <ø> (+0.51%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sundials_matrix_wrapper.cpp 81.02% <0.00%> (+0.81%) ⬆️
...thon/sdist/amici/conserved_quantities_demartino.py 65.55% <0.00%> (+1.95%) ⬆️
python/sdist/amici/gradient_check.py 96.84% <0.00%> (+13.68%) ⬆️

@dweindl
dweindl marked this pull request as ready for review January 16, 2023 10:19
@dweindl
dweindl requested a review from FFroehlich January 16, 2023 10:19
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FFroehlich FFroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@dweindl
dweindl merged commit 0d371d8 into develop Jan 16, 2023
@dweindl
dweindl deleted the binder branch January 16, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants