Skip to content

Fix RData documentation#1424

Merged
FFroehlich merged 11 commits intodevelopfrom
fix_1421
Feb 18, 2021
Merged

Fix RData documentation#1424
FFroehlich merged 11 commits intodevelopfrom
fix_1421

Conversation

@FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Feb 17, 2021

fixes #1421

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1424 (c8b95e1) into develop (fb08ed4) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1424      +/-   ##
===========================================
+ Coverage    78.76%   78.88%   +0.11%     
===========================================
  Files           66       66              
  Lines        10061    10061              
===========================================
+ Hits          7925     7937      +12     
+ Misses        2136     2124      -12     
Flag Coverage Δ
cpp 75.52% <ø> (+0.17%) ⬆️
petab 69.48% <ø> (ø)
python 67.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/model.h 66.66% <ø> (ø)
include/amici/rdata.h 94.44% <ø> (ø)
src/solver_cvodes.cpp 70.41% <0.00%> (+0.20%) ⬆️
src/sundials_matrix_wrapper.cpp 84.25% <0.00%> (+0.63%) ⬆️
src/spline.cpp 71.57% <0.00%> (+6.31%) ⬆️
src/exception.cpp 91.30% <0.00%> (+8.69%) ⬆️

@FFroehlich FFroehlich changed the title test Fix RData documentation Feb 17, 2021
@FFroehlich FFroehlich requested a review from dweindl February 17, 2021 21:56
@FFroehlich FFroehlich marked this pull request as ready for review February 17, 2021 21:56
@FFroehlich
Copy link
Member Author

fixes #1421

Maybe for future reference, not clear why, but doxygen/sphinx don't like colons in docstrings ...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit 0aa27b6 into develop Feb 18, 2021
@FFroehlich FFroehlich deleted the fix_1421 branch February 18, 2021 02:15
@dweindl dweindl linked an issue Feb 19, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

garbled rdata documentation

2 participants