Skip to content

Move ModelState and ModelDimension classes to separate files#1416

Merged
dweindl merged 3 commits intodevelopfrom
refactor_split
Feb 12, 2021
Merged

Move ModelState and ModelDimension classes to separate files#1416
dweindl merged 3 commits intodevelopfrom
refactor_split

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Feb 12, 2021

... because thousands of line per file are a pain

(Only moving code, no further changes)

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #1416 (d10f9fb) into develop (e657f37) will decrease coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1416      +/-   ##
===========================================
- Coverage    78.77%   78.74%   -0.03%     
===========================================
  Files           65       66       +1     
  Lines        10061    10061              
===========================================
- Hits          7926     7923       -3     
- Misses        2135     2138       +3     
Flag Coverage Δ
cpp 75.31% <77.77%> (-0.05%) ⬇️
petab 69.48% <ø> (ø)
python 67.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/model.h 66.66% <ø> (-4.17%) ⬇️
src/model_state.cpp 77.77% <77.77%> (ø)
src/exception.cpp 82.60% <0.00%> (-8.70%) ⬇️
src/solver_cvodes.cpp 70.20% <0.00%> (-0.21%) ⬇️

@sonarqubecloud
Copy link

@dweindl dweindl merged commit dc26399 into develop Feb 12, 2021
@dweindl dweindl deleted the refactor_split branch February 12, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants