Refactor(C++): Extract SimulationParameters from Model and ExpData#1407
Merged
Refactor(C++): Extract SimulationParameters from Model and ExpData#1407
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1407 +/- ##
===========================================
+ Coverage 78.70% 78.82% +0.12%
===========================================
Files 63 65 +2
Lines 10008 10061 +53
===========================================
+ Hits 7877 7931 +54
+ Misses 2131 2130 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using Model without ExpData unless there really are measurements. Also avoids having to add any new member of ExpData also to Model and slims down Model a bit. Getters and setters for SimulationParameters members are still in Model, which is to preserve backwards compatibility for ExpData, which allowed unchecked access to the respective members. Further refactoring to follow.
Partially addresses #931 (moving ID / name functions is still missing).