Skip to content

Add w to root signature #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dilpath merged 3 commits into from
Feb 6, 2021
Merged

Add w to root signature #1404

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b4b670
add w to root signature
dilpath Feb 5, 2021
311aad1
sub w expressions in roots
dilpath Feb 5, 2021
bd4bca4
rewrite comment
dilpath Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions python/amici/ode_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,6 +1173,16 @@ def transform_dxdt_to_concentration(specie_id, dxdt):

# fill in 'self._sym' based on prototypes and components in ode_model
self.generate_basic_variables(from_sbml=True)
# substitute 'w' expressions into event expressions now, to avoid
# rewriting '{model_name}_root.cpp' headers to include 'w.h'
for index, event in enumerate(self._events):
self._events[index] = Event(
identifier=event.get_id(),
name=event.get_name(),
value=event.get_val().subs(zip(self._syms['w'], self.eq('w'))),
state_update=event._state_update,
event_observable=event._observable,
)
self._has_quadratic_nllh = all(
llh['dist'] in ['normal', 'lin-normal']
for llh in si.symbols[SymbolId.LLHY].values()
Expand Down