Skip to content

Python: Add numpy minimum version requirements#1403

Merged
FFroehlich merged 1 commit intodevelopfrom
fix_numpy
Feb 4, 2021
Merged

Python: Add numpy minimum version requirements#1403
FFroehlich merged 1 commit intodevelopfrom
fix_numpy

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Feb 3, 2021

Should prevent errors like

RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
[...]
ImportError: numpy.core.multiarray failed to import

Should prevent errors like

```
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
[...]
ImportError: numpy.core.multiarray failed to import
```
@dweindl dweindl requested a review from FFroehlich February 3, 2021 21:47
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1403 (0edb1a6) into develop (afcb2e2) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1403      +/-   ##
===========================================
+ Coverage    78.66%   78.72%   +0.05%     
===========================================
  Files           63       63              
  Lines        10008    10008              
===========================================
+ Hits          7873     7879       +6     
+ Misses        2135     2129       -6     
Flag Coverage Δ
cpp 75.26% <ø> (+0.08%) ⬆️
petab 69.48% <ø> (ø)
python 67.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sundials_matrix_wrapper.cpp 83.82% <0.00%> (ø)
src/spline.cpp 71.57% <0.00%> (+6.31%) ⬆️

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FFroehlich FFroehlich merged commit bb9706c into develop Feb 4, 2021
@FFroehlich FFroehlich deleted the fix_numpy branch February 4, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants