Skip to content

Avoid segfault in cvodes CVAdataStore#1400

Merged
dweindl merged 2 commits intodevelopfrom
fix_segfault
Feb 2, 2021
Merged

Avoid segfault in cvodes CVAdataStore#1400
dweindl merged 2 commits intodevelopfrom
fix_segfault

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Feb 1, 2021

Re-apply #1351 to updated sundials

Re-apply #1351 to updated sundials
@dweindl dweindl requested a review from FFroehlich February 1, 2021 22:34
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #1400 (a91a347) into develop (88ba9bd) will increase coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1400      +/-   ##
===========================================
+ Coverage    78.70%   79.10%   +0.40%     
===========================================
  Files           63       63              
  Lines         9950    10568     +618     
===========================================
+ Hits          7831     8360     +529     
- Misses        2119     2208      +89     
Flag Coverage Δ
cpp 75.19% <ø> (+0.01%) ⬆️
petab 69.50% <ø> (ø)
python 67.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/ode_export.py 90.03% <0.00%> (-2.74%) ⬇️
python/amici/sbml_import.py 94.72% <0.00%> (-1.35%) ⬇️
src/sundials_matrix_wrapper.cpp 83.61% <0.00%> (+0.21%) ⬆️

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl dweindl merged commit 8f7ef5c into develop Feb 2, 2021
@dweindl dweindl deleted the fix_segfault branch February 2, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants