Refactor amici::Model - extract ModelDimensions#1395
Merged
Conversation
update code generation and templates
Codecov Report
@@ Coverage Diff @@
## develop #1395 +/- ##
===========================================
+ Coverage 78.67% 78.76% +0.09%
===========================================
Files 63 63
Lines 9925 9937 +12
===========================================
+ Hits 7808 7827 +19
+ Misses 2117 2110 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
sphinx failing? also not sure about the sonarcloud bugs. |
|
SonarCloud Quality Gate failed. |
Member
Author
Timeout. Previously working.
Old code smells in amici::Model. Too many members/arguments, mix of private/public data members |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor amici::Model and amici::ReturnData, extract ModelDimensions to reduce redundancy.