Skip to content

Require CMake>=3.3 for generated models#1387

Merged
dweindl merged 4 commits intodevelopfrom
cmake_minimum_required
Jan 29, 2021
Merged

Require CMake>=3.3 for generated models#1387
dweindl merged 4 commits intodevelopfrom
cmake_minimum_required

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jan 29, 2021

  • Require CMake>=3.3 for generated models (Fixes CMake deprecation warning)

Fixes CMake deprecation warning
@dweindl dweindl requested review from FFroehlich and removed request for FFroehlich January 29, 2021 16:37
@dweindl dweindl marked this pull request as draft January 29, 2021 16:39
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1387 (87134b5) into develop (8c440e9) will increase coverage by 3.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1387      +/-   ##
===========================================
+ Coverage    75.31%   78.72%   +3.41%     
===========================================
  Files           22       63      +41     
  Lines         3168     9920    +6752     
===========================================
+ Hits          2386     7810    +5424     
- Misses         782     2110    +1328     
Flag Coverage Δ
cpp 75.25% <ø> (?)
petab 69.50% <ø> (ø)
python 68.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/abstract_model.cpp 3.09% <0.00%> (ø)
include/amici/edata.h 0.00% <0.00%> (ø)
src/edata.cpp 88.23% <0.00%> (ø)
src/steadystateproblem.cpp 78.75% <0.00%> (ø)
include/amici/model_dae.h 0.00% <0.00%> (ø)
src/model_dae.cpp 48.17% <0.00%> (ø)
src/rdata.cpp 94.93% <0.00%> (ø)
src/spline.cpp 71.57% <0.00%> (ø)
src/exception.cpp 82.60% <0.00%> (ø)
src/forwardproblem.cpp 91.51% <0.00%> (ø)
... and 42 more

@dweindl dweindl marked this pull request as ready for review January 29, 2021 18:05
@dweindl dweindl merged commit c432a0b into develop Jan 29, 2021
@dweindl dweindl deleted the cmake_minimum_required branch January 29, 2021 18:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants