Skip to content

Commit

Permalink
initial changes to adopt collection (Azure#24835)
Browse files Browse the repository at this point in the history
* add GetDefaultSubscriptionAsync

* update tests

* re-record tests

* fix more tests

* remove commented code

* fix pragma

* Update sdk/resourcemanager/Azure.ResourceManager/README.md

Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>

* remove _defaultSubscriptionId

* initial changes to adopt collection

* update changelog and examples

* temp remove collection reference to mock test base
update remaining collecitons

* update api

* update docs / readme

* use InvalidOperationException

* update core references

* update compute tests

* fix remaining compute tests

* fix keyvault tests

* fix resources tests

* fix network tests

* regen predefined tests

* update tagresource since the collection isn't

* update test casing

* update enurable interface to be internal impl

* update api

* fix resources tests

* update network tests

* revert resourcemanager reference

* revert the recordings of some compute tests

* update after merge and re-record

* update snippets

* update change log

* temporary remove network / compute reference

* Update AutoRest C# version to 3.0.0-beta.20211026.1

* update version of arm to alpha in data.props
update storage reference in network to proj (tmp)
update test cases (not recorded)

* update to list exceptions

* update compute tests

* update keyvault tests

* update resources tests

* update network tests

* update storage tests

* fix llc tests

* fix snippets

* fix container name in multiple tests

* change to proj ref

* update appconfig

* update dns

* update cosmos

* update storage to use proj ref temporarily

* update communication

* update eventhubs

* update insights

* update ml

* update sql

* update few remaining md references to container

Co-authored-by: Feng Zhou <fenzhou@microsoft.com>
Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>
Co-authored-by: Yao Kou <yaokou@microsoft.com>
Co-authored-by: azure-sdk <azuresdk@microsoft.com>
  • Loading branch information
5 people authored Oct 28, 2021
1 parent f485e69 commit c8bd793
Show file tree
Hide file tree
Showing 856 changed files with 263,526 additions and 109,821 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ protected async Task CleanupResourceGroupsAsync()
}
}

protected async Task<string> GetFirstUsableLocationAsync(ProviderContainer providersClient, string resourceProviderNamespace, string resourceType)
protected async Task<string> GetFirstUsableLocationAsync(ProviderCollection providersClient, string resourceProviderNamespace, string resourceType)
{
var provider = (await providersClient.GetAsync(resourceProviderNamespace)).Value;
return provider.Data.ResourceTypes.Where(
Expand Down
7 changes: 0 additions & 7 deletions common/ManagementTestShared/Redesign/MockTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,6 @@ public MockTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
EnsureMockServerRunning();
}

protected async Task<ResourceGroupContainer> GetResourceGroupContainer(ArmClientOptions clientOptions = default)
{
var client = GetArmClient(clientOptions);
var sub = await client.GetSubscriptions().GetAsync(TestEnvironment.SubscriptionId);
return sub.Value.GetResourceGroups();
}

private void EnsureMockServerRunning()
{
if (Mode == RecordedTestMode.Record)
Expand Down
4 changes: 2 additions & 2 deletions eng/Packages.Data.props
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@

<!-- Packages intended for Management libraries only -->
<ItemGroup Condition="'$(IsMgmtSubLibrary)' == 'true'">
<PackageReference Update="Azure.ResourceManager" Version="1.0.0-beta.4" />
<PackageReference Update="Azure.ResourceManager" Version="1.0.0-alpha.20211025.2" />
</ItemGroup>

<!-- Packages intended for Extensions libraries only -->
Expand All @@ -146,7 +146,7 @@
All should have PrivateAssets="All" set so they don't become package dependencies
-->
<ItemGroup>
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20211019.1" PrivateAssets="All" />
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20211026.2" PrivateAssets="All" />
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20210903.4" PrivateAssets="All" />
<PackageReference Update="coverlet.collector" Version="1.3.0" PrivateAssets="All" />
<PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1" PrivateAssets="All" />
Expand Down

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit c8bd793

Please sign in to comment.