fix test namespace (Azure#23755)

fix wait for completion in base test class add bastion host create test
AME-Redmond · Sep 8, 2021 · 56f2c96 · 56f2c96
1 parent ed1a5ba
commit 56f2c96
Show file tree

Hide file tree

Showing 53 changed files with 175,458 additions and 44 deletions.
diff --git a/common/ManagementTestShared/Redesign/ManagementRecordedTestBase.cs b/common/ManagementTestShared/Redesign/ManagementRecordedTestBase.cs
@@ -105,7 +105,7 @@ protected void CleanupResourceGroups()
                     try
                     {
                         var sub = _cleanupClient.GetSubscriptions().GetIfExists(TestEnvironment.SubscriptionId);
-                        sub.Value?.GetResourceGroups().Get(resourceGroup).Value.Delete();
+                        sub.Value?.GetResourceGroups().Get(resourceGroup).Value.Delete(waitForCompletion: false);
                     }
                     catch (RequestFailedException e) when (e.Status == 404)
                     {
@@ -117,7 +117,7 @@ protected void CleanupResourceGroups()
                 {
                     try
                     {
-                        _cleanupClient.GetManagementGroup(mgmtGroupId).Delete();
+                        _cleanupClient.GetManagementGroup(mgmtGroupId).Delete(waitForCompletion: false);
                     }
                     catch (RequestFailedException e) when (e.Status == 404 || e.Status == 403)
                     {
@@ -202,11 +202,11 @@ public void OneTimeCleanupResourceGroups()
                 Parallel.ForEach(OneTimeResourceGroupCleanupPolicy.ResourceGroupsCreated, resourceGroup =>
                 {
                     var sub = _cleanupClient.GetSubscriptions().GetIfExists(SessionEnvironment.SubscriptionId);
-                    sub.Value?.GetResourceGroups().Get(resourceGroup).Value.Delete();
+                    sub.Value?.GetResourceGroups().Get(resourceGroup).Value.Delete(waitForCompletion: false);
                 });
                 Parallel.ForEach(OneTimeManagementGroupCleanupPolicy.ManagementGroupsCreated, mgmtGroupId =>
                 {
-                    _cleanupClient.GetManagementGroup(mgmtGroupId).Delete();
+                    _cleanupClient.GetManagementGroup(mgmtGroupId).Delete(waitForCompletion: false);
                 });
             }
 

diff --git a/sdk/network/Azure.ResourceManager.Network/tests/Helpers/NetworkServiceClientTestBase.cs b/sdk/network/Azure.ResourceManager.Network/tests/Helpers/NetworkServiceClientTestBase.cs
@@ -10,21 +10,23 @@
 using Azure.ResourceManager.Resources;
 using Azure.ResourceManager.Resources.Models;
 using Azure.ResourceManager.Network.Models;
-using Azure.ResourceManager.Network.Tests.Tests;
 using Azure.ResourceManager.TestFramework;
 
 using NUnit.Framework;
 
 namespace Azure.ResourceManager.Network.Tests.Helpers
 {
-    [RunFrequency(RunTestFrequency.Manually)]
     public class NetworkServiceClientTestBase : ManagementRecordedTestBase<NetworkManagementTestEnvironment>
     {
         private const string dummySSHKey = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC+wWK73dCr+jgQOAxNsHAnNNNMEMWOHYEccp6wJm2gotpr9katuF/ZAdou5AaW1C61slRkHRkpRRX9FA9CYBiitZgvCCz+3nWNN7l/Up54Zps/pHWGZLHNJZRYyAB6j5yVLMVHIHriY49d/GZTZVNB8GoJv9Gakwc/fuEZYYl4YDFiGMBP///TzlI4jhiJzjKnEvqPFki5p2ZRJqcbCiF4pJrxUQR/RXqVFQdbRLZgYfJ8xGB878RENq3yQ39d8dVOkq4edbkzwcUmwwwkYVPIoDGsYLaRHnG+To7FvMeyO7xDVQkMKzopTQV8AuKpyvpqu0a9pWOMaiCyDytO7GGN you@me.com";
         public NetworkServiceClientTestBase(bool isAsync) : base(isAsync)
         {
         }
 
+        public NetworkServiceClientTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
+        {
+        }
+
         public bool IsTestTenant = false;
         public static TimeSpan ZeroPollingInterval { get; } = TimeSpan.FromSeconds(0);
         public Dictionary<string, string> Tags { get; internal set; }