Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from whatwg:main #82

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+55 −5
Open

[pull] main from whatwg:main #82

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec17802
Redefine dialog closedby IDL attribute to return the computed value
keithamus Feb 27, 2025
2edb8cc
Upstream XMLSerializer from DOM Parsing and Serialization
lukewarlow Feb 28, 2025
17d4497
Editorial: replace remaining link to import attributes proposal
nicolo-ribaudo Feb 28, 2025
98c0f89
Editorial: remove %JSON.parse% intrinsic reference
nicolo-ribaudo Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Redefine dialog closedby IDL attribute to return the computed value 
This fixes whatwg#10945 by moving the IDL attribute away from reflection and instead define getter (in terms of the computed closed-by state) and setter steps.
  • Loading branch information
@keithamus
keithamus authored Feb 27, 2025
commit ec17802cdff3122c9a0e20a393d134ab61c98763
8 changes: 5 additions & 3 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62279,9 +62279,11 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
is created, it must be set to the empty string.</p>

<p>The <dfn attribute for="HTMLDialogElement"><code
data-x="dom-dialog-closedBy">closedBy</code></dfn> IDL attribute must <span>reflect</span> the
<code data-x="attr-dialog-closedby">closedby</code> content attribute, <span>limited to only
known values</span>.</p>
data-x="dom-dialog-closedBy">closedBy</code></dfn> getter steps are to return the keyword
corresponding to the <span>computed closed-by state</span> given <span>this</span>.</p>

<p>The <code data-x="dom-dialog-closedBy">closedBy</code> setter steps are to set the <code
data-x="attr-dialog-closedby">closedby</code> content attribute to the given value.</p>

<p>The <dfn attribute for="HTMLDialogElement"><code data-x="dom-dialog-open">open</code></dfn> IDL
attribute must <span>reflect</span> the <code data-x="attr-dialog-open">open</code> content
Expand Down