Connect authentication service to notification service #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
jusoto
approved these changes
Jul 20, 2018
dmssargent
approved these changes
Jul 20, 2018
build.gradle
Outdated
| compile('org.springframework.boot:spring-boot-starter-web') | ||
| compile('org.springframework.boot:spring-boot-starter-actuator') | ||
| compile('org.springframework.boot:spring-boot-starter-amqp') |
docker-compose.yml
Outdated
| environment: | ||
| - RABBIT_HOST=rabbitmq | ||
|
|
||
|
|
dmssargent
suggested changes
Jul 23, 2018
| if (evt.getSource() instanceof UsernamePasswordAuthenticationToken) { | ||
| User user = (User) evt.getAuthentication().getPrincipal(); | ||
| log.info(String.format("User %s logged in", user.getUsername())); | ||
| producer.send(String.format("{\"userId\":\"%s\"}", user.getUsername())); |
There was a problem hiding this comment.
You should be using the current user id, not the user name.
…docker-compose-local.yml
dmssargent
approved these changes
Jul 23, 2018
jacobkissel
previously requested changes
Jul 23, 2018
|
|
||
| public void send(String message) { | ||
| log.info(String.format("Sending message %s to %s", message, topicExchange.getName())); | ||
| this.rabbitTemplate.convertAndSend(topicExchange.getName(), "notification.user.authentication", message); |
There was a problem hiding this comment.
Routing key should be like this: {bounded-context}.{aggregate-name}.{what-happened-in-past-tense}
So like notification.user.userauthenticated or something maybe
…Listener to avoid confusion between model.User and uderdetails.User. Updated test to use SpringRunner.class, defined random port and single declaration of hostUrl. In WebSecurityConfigurer disabled http.headers to solve issue with front-end
… front-end due to edge-service is also adding these headers. Added a try catch for exceptions when sending the message to notification service
ghost
dismissed
jacobkissel’s stale review
I fixed what he requested, but he is not available to change his response himself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.