Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shap fix #762

Merged
merged 12 commits into from
Jun 24, 2024
Merged

Shap fix #762

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0d05f9a
testing without additivity and stuff
isaacmg Jun 19, 2024
75dc3b3
Revert "testing without additivity and stuff"
isaacmg Jun 19, 2024
045f001
fiing the code
isaacmg Jun 19, 2024
7445008
Merge branch 'master' into shap_fixes
isaacmg Jun 19, 2024
a4c2026
Merge branch 'master' into shap_fixes
isaacmg Jun 19, 2024
05e065c
Merge branch 'master' into shap_fixes
isaacmg Jun 19, 2024
98a37d5
set additivity to false and all
isaacmg Jun 20, 2024
0889399
remove final additivity check
isaacmg Jun 20, 2024
d66a0fb
Revert "remove final additivity check"
isaacmg Jun 20, 2024
a10ca4e
fixing everything
isaacmg Jun 20, 2024
2f1ea7a
Merge branch 'master' into shap_fixes
isaacmg Jun 20, 2024
ff5cd9a
fixing all syha 2
isaacmg Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing everything
  • Loading branch information
@isaacmg
isaacmg committed Jun 20, 2024
commit a10ca4e9815bdd7d09630949036a022c0276c8ca
2 changes: 1 addition & 1 deletion flood_forecast/evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def get_model_r2_score(
):
"""

model_evaluate_function should call any necessary preprocessing
model_evaluate_function should call any necessary preprocessing.
"""
test_river_data, baseline_mse = stream_baseline(river_flow_df, forecast_column)

Expand Down
2 changes: 1 addition & 1 deletion flood_forecast/explain_model_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def deep_explain_model_summary_plot(
hist.cpu().numpy(), names=["batches", "observations", "features"]
)

shap_values = deep_explainer.shap_values(history)
shap_values = deep_explainer.shap_values(history, check_additivity=False)
shap_values = fix_shap_values(shap_values, history)
shap_values = np.stack(shap_values)
if len(shap_values.shape) != 4:
Expand Down