Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Error-fix #73

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Syntax Error-fix #73

merged 1 commit into from
Mar 1, 2024

Conversation

swalehmwadime
Copy link
Contributor

Syntax Error 1:

import supervision as a SV statement at the beginning of the script.
There is no module named supervision in the standard Python libraries, nor is it imported from elsewhere in the script.
Potential Fix: Remove or replace this import statement with the correct module import.

Syntax Error 2:

def inference_detector(runner, image_path, texts, max_dets, score_thr, output_dir, use_amp=False, show=False): function definition.
The use_amp and show parameters have default values but are listed after parameters without default values.
Potential Fix: Rearrange the function parameters so that those with default values come after those without default values.

Syntax Error 3:

cv2.imshow(image) and cv2.destroyAllWindows() inside the if show: block.
The cv2.imshow() function requires a window name as the first argument.
Potential Fix: Provide a window name parameter to cv2.imshow().

@onuralpszr
Copy link
Contributor

supervision is library you need to install and you can install via "pip install supervision"

@wondervictor wondervictor merged commit 8b998c9 into AILab-CVC:master Mar 1, 2024
@taofuyu
Copy link
Contributor

taofuyu commented Mar 13, 2024

this PR should not be merged, it has some errors.
@wondervictor

For example, it delete sv, but sv is still used.

It defines a none var, and immediately use it.

This makes image_demo.py wrong.

@wondervictor
Copy link
Collaborator

Hi @taofuyu, thanks and I'll check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants