feat: support NOT_GIVEN type #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etang-ai21
force-pushed
the
support_not_given_type
branch
2 times, most recently
from
2c5107b to
001acc5
Compare
asafgardin
reviewed
Feb 25, 2024
Contributor
|
@etang-ai21 Looks great! I would consider adding it to other resources where we pass optional. I can do it in a different PR if you want |
etang-ai21
force-pushed
the
support_not_given_type
branch
2 times, most recently
from
eefb948 to
39bdcbf
Compare
asafgardin
approved these changes
Feb 25, 2024
etang-ai21
force-pushed
the
support_not_given_type
branch
from
39bdcbf to
4777b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.