Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override equal for derived predicates #74

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Override equal for derived predicates #74

merged 2 commits into from
Jun 5, 2023

Conversation

francescofuggitti
Copy link
Collaborator

@francescofuggitti francescofuggitti commented Jun 1, 2023

Proposed changes

Add custon eq operator to Predicates and Derived Predicates

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@codecov-commenter
Copy link

Codecov Report

Merging #74 (173de51) into main (ad68c05) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   88.30%   88.23%   -0.08%     
==========================================
  Files          20       20              
  Lines        1052     1054       +2     
  Branches      164      164              
==========================================
+ Hits          929      930       +1     
- Misses         95       96       +1     
  Partials       28       28              
Flag Coverage Δ
unittests 88.23% <50.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pddl/logic/predicates.py 83.52% <50.00%> (-0.81%) ⬇️

Copy link
Contributor

@haz haz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we could get a test on this one? I assume it was breaking on == checks before the change?

Copy link
Contributor

@haz haz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we could get a test on this one? I assume it was breaking on == checks before the change?

@haz
Copy link
Contributor

haz commented Jun 2, 2023

codecov is not happy ;)

image

@francescofuggitti francescofuggitti requested a review from haz June 2, 2023 18:57
Copy link
Member

@marcofavorito marcofavorito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@haz haz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test cases!

@haz haz merged commit e9669dd into main Jun 5, 2023
@marcofavorito marcofavorito deleted the fix/der-pred branch June 5, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants