-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development maintainance #60
Conversation
Python 3.7 is a bit too obsolete (at the time of writing). Python 3.10 seems a better choice as a Python interpreter version for setting up the development environment. Moreover, version 3.7 is reaching end-of-life in a month: https://devguide.python.org/versions/
…ion} for testenv name This convention is more "tox-friendly", since an environment with 'py$MAJOR$MINOR' in its name will use the Python interpreter at version $MAJOR.MINOR as base python. In particular, in this way, we could avoid the repetition of different testenv configurations which only differ by the basepython variable. This change required a workaround in the GitHub Actions workflow configuration, since the Python version there has a dot that separates major and minor versions.
27cd69c
to
297fef9
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 87.33% 87.34% +0.01%
==========================================
Files 20 20
Lines 1050 1051 +1
Branches 163 163
==========================================
+ Hits 917 918 +1
Misses 104 104
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Upgrade the development dependencies. For each dependency, the latest version is used as lower-bound of the version specifier set; as upper-bound, the same version number but with the minor number increased by one and patch number set to 0.
Import was detected as unused because the type hinting was used in the form \# type: Type
This was due to an incompatibility with a newer version of isort. https://github.com/AI-Planning/pddl/actions/runs/4963214887/jobs/8882204405?pr=60#step:5:67
8cca99f
to
9be3209
Compare
3ebb200
to
375c14a
Compare
375c14a
to
010c75a
Compare
7f0bbce
to
0fceb87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Aye, looks good. Let's see how the build goes ;) |
Proposed changes
This PR provides various fixes and improvements, mostly on the development environment.
Most important changes:
chore: bump Python interpreter version to 3.10 in Pipfile: Python 3.7 is a bit too obsolete (at the time of writing). Python 3.10 seems a better choice as a Python interpreter version for setting up the development environment. Moreover, version 3.7 is reaching end-of-life in a month: https://devguide.python.org/versions/
test: use py3{py-minor-version} format rather than py3.{py-minor-version} for testenv name: This convention is more "tox-friendly", since an environment with 'py$MAJOR$MINOR' in its name will use the Python interpreter at version $MAJOR.MINOR as base python. In particular, in this way, we could avoid the repetition of different testenv configurations which only differ by the basepython variable. This change required a workaround in the GitHub Actions workflow configuration, since the Python version there has a dot that separates major and minor versions.
chore: upgrade dev dependencies Upgrade the development dependencies. For each dependency, the latest version is used as lower-bound of the version specifier set; as upper-bound, the same version number but with the minor number increased by one and patch number set to 0.
ci: fix tox version in CI, to make the CI behaviour more similar to local dev environment
ci: remove Python version 3.7 from linting workflow: This was due to an incompatibility with a newer version of isort.
fix code according to new failures caused by tools upgrade: bcc26e0, 1536c78, 939d5f8
lint: add safety checker (partially addresse https://github.com/AI-Planning/pddl/issues/61[)](https://github.com/AI-Planning/pddl/pull/60/commits/409e31c0b89b22833c61b701b8f6bc6436510c49)
lint: add bandit checker (partially address https://github.com/AI-Planning/pddl/issues/61[)](https://github.com/AI-Planning/pddl/pull/60/commits/375c14a61b685ce55f5f0474fd4ceb354f0da08e), and resolve new issues (010c75a)
Fixes
n/a
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.Further comments
n/a