Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development maintainance #60

Merged
merged 14 commits into from
May 15, 2023
Merged

Development maintainance #60

merged 14 commits into from
May 15, 2023

Conversation

marcofavorito
Copy link
Member

@marcofavorito marcofavorito commented May 12, 2023

Proposed changes

This PR provides various fixes and improvements, mostly on the development environment.

Most important changes:

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

Python 3.7 is a bit too obsolete (at the time of writing).
Python 3.10 seems a better choice as a Python interpreter version for setting up the development environment.

Moreover, version 3.7 is reaching end-of-life in a month: https://devguide.python.org/versions/
…ion} for testenv name

This convention is more "tox-friendly", since an environment with 'py$MAJOR$MINOR'
in its name will use the Python interpreter at version $MAJOR.MINOR as base python.

In particular, in this way, we could avoid the repetition of different testenv
configurations which only differ by the basepython variable.

This change required a workaround in the GitHub Actions workflow configuration,
since the Python version there has a dot that separates major and minor versions.
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #60 (0fceb87) into main (75ecdf4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   87.33%   87.34%   +0.01%     
==========================================
  Files          20       20              
  Lines        1050     1051       +1     
  Branches      163      163              
==========================================
+ Hits          917      918       +1     
  Misses        104      104              
  Partials       29       29              
Flag Coverage Δ
unittests 87.34% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pddl/__init__.py 100.00% <ø> (ø)
pddl/helpers/base.py 93.75% <100.00%> (ø)
pddl/parser/domain.py 79.89% <100.00%> (ø)
pddl/parser/problem.py 85.33% <100.00%> (+0.19%) ⬆️
pddl/parser/symbols.py 100.00% <100.00%> (ø)

@marcofavorito marcofavorito marked this pull request as ready for review May 13, 2023 09:43
Upgrade the development dependencies. For each dependency, the latest version
is used as lower-bound of the version specifier set; as upper-bound, the
same version number but with the minor number increased by one and patch number set to 0.
Import was detected as unused because the type hinting was used in the form
\# type: Type
Copy link
Collaborator

@francescofuggitti francescofuggitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haz haz merged commit fa78d45 into main May 15, 2023
@haz
Copy link
Contributor

haz commented May 15, 2023

Aye, looks good. Let's see how the build goes ;)

@marcofavorito marcofavorito deleted the dev-maintainance branch June 5, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants