Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider shifting to pddl #1

Open
haz opened this issue Nov 4, 2022 · 9 comments
Open

Consider shifting to pddl #1

haz opened this issue Nov 4, 2022 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed on-hold Will be addressed in the future, but not right now.

Comments

@haz
Copy link
Contributor

haz commented Nov 4, 2022

If there's a desire to extend things to more general forms of PDDL expressivity, then a more flexible library might be useful. pddl is a decent candidate (already expressive, and easy-to-extend lark for the parsing context).

@haz haz added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 4, 2022
@TheAeryan
Copy link
Collaborator

Since right now I am a little bit busy, I think I will look into pddl once I start adding more functionality into Lifted PDDL. By this I mean I will 1) integrate pddl into Lifted PDDL and, then, 2) add extra functionality such as conditional effects, negative preconditions, etc.

@TheAeryan
Copy link
Collaborator

Since my next step is to implement existential preconditions (:exists) in Lifted PDDL, I have just taken a look at pddl. However, from the Readme, it seems that it does not support that PDDL requirement yet.

@haz
Copy link
Contributor Author

haz commented Nov 14, 2022

Let's see...

AI-Planning/pddl#40

Anything else that would be required?

@TheAeryan
Copy link
Collaborator

Right now I am using Typed STRIPS + existential preconditions, so nothing else for now.

@TheAeryan
Copy link
Collaborator

From our previous conversation, I think it would be a good idea to also have support for universal effects (forall when) and, maybe, all the ADL requirements. In the future I would like to extend Lifted PDDL so that it supports ADL, so it is a matter of when ADL will be supported by pddl. If they have no intention to support it in the near future (since it is a lot of work), maybe I should stick to tarski, since they already support ADL (to the best of my knowledge).

@haz
Copy link
Contributor Author

haz commented Nov 15, 2022

Aye, fair enough. Not sure how big of a task it'll be in the end, and something pddl definitely should implement. So we'll see when they respond to the new issue.

@TheAeryan
Copy link
Collaborator

For now, I think I'll stick to tarski since I need support for existential preconditions ASAP. But in the future I'll consider shifting to pddl if they have implemented support for ADL by then.

@TheAeryan TheAeryan added the on-hold Will be addressed in the future, but not right now. label Nov 15, 2022
@TheAeryan TheAeryan closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2022
@haz
Copy link
Contributor Author

haz commented Nov 16, 2022

Not sure it needs to be closed out -- feel free to leave it on hold and assign me. I'll have a look into what's required on the pddl front for full-on ADL.

@haz
Copy link
Contributor Author

haz commented Nov 18, 2022

Re-opening, as we're about to have full ADL support drop.

@haz haz reopened this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed on-hold Will be addressed in the future, but not right now.
Projects
None yet
Development

No branches or pull requests

2 participants