Skip to content

Conversation

RoshaniN
Copy link
Contributor

@RoshaniN RoshaniN commented Feb 4, 2025

Fixes / Features

  • Adds support for adding Pathways proxy, server and worker args.
  • Ensures indentation of added args is in line with the rest of the YAML.

Testing / Documentation

Manually verified -
Command -

python3 ~/xpk/xpk.py workload create-pathways \
--workload roshanin-pw-test${n} \
--num-slices=1 \
--tpu-type=$TPU_TYPE \
--project $PROJECT \
--zone $ZONE \
--cluster $CLUSTER \
--headless \
--custom-pathways-server-args='--temporary_flags_for_debugging=temporary_flag_for_debugging_worker_expected_tpu_chip_config=megachip_tccontrol'

YAML output -

template:
          spec:
            containers:
            - args:
              - --server_port=29001
              - --gcs_scratch_location=gs://cloud-pathways-staging/tmp
              - --node_type=resource_manager
              - --instance_count=1
              - --instance_type=tpuv6e:16x16
              - --temporary_flags_for_debugging=temporary_flag_for_debugging_worker_expected_tpu_chip_config=megachip_tccontrol          
  • [ y ] Tests pass
  • [ y ] Appropriate changes to documentation are included in the PR

@RoshaniN RoshaniN requested a review from shauryagup February 4, 2025 20:36
@RoshaniN RoshaniN force-pushed the roshanin_args branch 2 times, most recently from 929463c to 7d586b6 Compare February 4, 2025 21:07
@RoshaniN RoshaniN merged commit 666b4c5 into main Feb 4, 2025
6 checks passed
@RoshaniN RoshaniN deleted the roshanin_args branch February 4, 2025 21:47
SujeethJinesh pushed a commit that referenced this pull request Feb 19, 2025
SujeethJinesh added a commit that referenced this pull request Feb 20, 2025
* Update the pod_name query for pathways workloads (#362)

* Support custom Pathways args. (#364)

* Remove Pathways specific args from workload create flow. (#365)

* Remove Pathways specific optional args from workload create.

* Deprecate --use-pathways from workload create, set it in create-pathways.

* Remove --enable-pathways from cluster create flow.

* Adding --use-pathways and --enable-pathways args - they are used to determine Pathways flows.

---------

Co-authored-by: Luke Baumann <lukebaumann@users.noreply.github.com>
Co-authored-by: Roshani Narasimhan <roshanin@google.com>
SujeethJinesh pushed a commit that referenced this pull request Feb 20, 2025
SujeethJinesh added a commit that referenced this pull request Feb 20, 2025
* Support custom Pathways args. (#364)

* Remove Pathways specific args from workload create flow. (#365)

* Remove Pathways specific optional args from workload create.

* Deprecate --use-pathways from workload create, set it in create-pathways.

* Remove --enable-pathways from cluster create flow.

* Adding --use-pathways and --enable-pathways args - they are used to determine Pathways flows.

* Add Workaround for Megascale Num Slices Issue on PW

---------

Co-authored-by: Roshani Narasimhan <roshanin@google.com>
sharabiani added a commit that referenced this pull request Mar 17, 2025
* Update the pod_name query for pathways workloads (#362)

* Support custom Pathways args. (#364)

* Remove Pathways specific args from workload create flow. (#365)

* Remove Pathways specific optional args from workload create.

* Deprecate --use-pathways from workload create, set it in create-pathways.

* Remove --enable-pathways from cluster create flow.

* Adding --use-pathways and --enable-pathways args - they are used to determine Pathways flows.

---------

Co-authored-by: Luke Baumann <lukebaumann@users.noreply.github.com>
Co-authored-by: Roshani Narasimhan <roshanin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants