[DRAFT] Making CloudDNS optional for Pathways-enabled clusters. #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoshaniN
requested review from
Obliviour,
44past4,
sharabiani,
pawloch00 and
BluValor
as code owners
RoshaniN
force-pushed
the
roshanin_clouddns
branch
from
dc737c7 to
b850df0
Compare
RoshaniN
force-pushed
the
roshanin_clouddns
branch
from
b850df0 to
05d5800
Compare
pawloch00
approved these changes
Oct 31, 2024
BluValor
reviewed
Nov 4, 2024
Comment on lines
+183
to
+190
| Please specify `--enable-clouddns` if you would like CloudDNS to be the | ||
| DNS provider for the Pathways cluster. For example, | ||
| ```shell | ||
| python3 xpk.py cluster create-pathways \ | ||
| --cluster xpk-pw-test-clouddns \ | ||
| --num-slices=4 --on-demand \ | ||
| --tpu-type=v5litepod-16 | ||
| ``` |
There was a problem hiding this comment.
Shouldn't we actually add the --enable-clouddns piece to the example command?
RoshaniN
changed the title
Obliviour
approved these changes
Dec 8, 2024
scaliby
requested review from
gcie,
scaliby,
jamOne-,
SikaGrr and
FIoannides
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing details.