Skip to content

Fix pyink formatting - #4939

Merged
copybara-service[bot] merged 1 commit into
mainfrom
htn-diloco-format
Aug 19, 2026
Merged

Fix pyink formatting#4939
copybara-service[bot] merged 1 commit into
mainfrom
htn-diloco-format

Conversation

@huytransformer

@huytransformer huytransformer commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix pyink formatting in spmd_diloco_checkpointing.py

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reformats several multi-line statements in spmd_diloco_checkpointing.py into single lines to improve readability and code conciseness. I have no feedback to provide as there are no review comments.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...trainers/diloco/utils/spmd_diloco_checkpointing.py 58.33% 3 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@copybara-service
copybara-service Bot merged commit 4ce4687 into main Aug 19, 2026
76 of 77 checks passed
@copybara-service
copybara-service Bot deleted the htn-diloco-format branch August 19, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants