Add support for Tokamax GMM v2 heuristic tiling function. - #4935
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add support for Tokamax GMM v2 heuristic tiling function.#4935copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
# Description This change introduces a new configuration option, use_gmm_v2_tiling_fn, which allows MaxText to use the heuristic tiling functions from Tokamax GMM v2 and TGMM v2 instead of custom tile sizes. The option is integrated into the MoE layer, Megablox GMM operations, configuration validation, and documentation. An integration test has also been added to verify the heuristic tiling path. # Tests ### E2E Test # Checklist Before submitting this PR, please make sure (put X in square brackets): - [] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [] I have necessary comments in my code, particularly in hard-to-understand areas. - [] I have run end-to-end tests tests and provided workload links above if applicable. - [] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation. PiperOrigin-RevId: 966100631
copybara-service
Bot
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jacoguzo,
jiangjy1982,
khatwanimohit,
michelle-yooh,
richjames0,
shralex,
shuningjin,
vipannalla,
xibinliu and
zxhe-sean
as code owners
August 18, 2026 18:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Tokamax GMM v2 heuristic tiling function.
Description
This change introduces a new configuration option, use_gmm_v2_tiling_fn, which allows MaxText to use the heuristic tiling functions from Tokamax GMM v2 and TGMM v2 instead of custom tile sizes. The option is integrated into the MoE layer, Megablox GMM operations, configuration validation, and documentation. An integration test has also been added to verify the heuristic tiling path.
Tests
E2E Test
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.